Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): empty warning message should work with multiple grids #158

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

ghiscoding
Copy link
Owner

  • also fix an issue with how to detect frozen grid, we need to check the frozenColumn instead of frozenRow

Ghislain Beaulac added 3 commits November 13, 2020 15:53
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #158 (8edef29) into master (83e5fc3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          198       198           
  Lines        11637     11637           
  Branches      3824      3824           
=========================================
  Hits         11637     11637           
Impacted Files Coverage Δ
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
...le/src/components/slick-empty-warning.component.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e5fc3...8edef29. Read the comment docs.

@ghiscoding ghiscoding merged commit 9e7c023 into master Nov 13, 2020
@ghiscoding ghiscoding deleted the bugfix/empty-warning-multiple-grids branch November 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant